Remove outdated comment #10853
Merged
Remove outdated comment #10853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since support for persistence 2 has been dropped, this method may no longer acces an aliased class name. Besides, providing an FQCN with a leading backslash should work since removing it is the first thing that happens inside AbstractClassMetadataFactory::getMetadataFor().
greg0ire
force-pushed
the
remove-outdated-comment
branch
from
68ac6bb
to
a370595
Compare
derrabus
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since support for persistence 2 has been dropped, this method may no longer acces an aliased class name.
Besides, providing an FQCN with a leading backslash should work since removing it is the first thing that happens inside
AbstractClassMetadataFactory::getMetadataFor(): https://github.com/doctrine/persistence/blob/413eb71a22c31c309b5a1cea9701d723cc0d4ae2/src/Persistence/Mapping/AbstractClassMetadataFactory.php#L164-L177